use log for errors, handle invalid flags and explicitly print to stdout #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! Sorry for the random unsolicited PR.
While exploring this tool, I naively ran
go-outline
without any arguments and saw:That got me thinking "Hm I feel this shouldn't panic, and if it can't parse the file, why does it continue trying to work".
log.Fatal
call.log
to have the prefix of the app, so that when run from scripts/tools, it's clear what tool is generating the error message.log
package too, but in a "do not explode, carry on" manner.json.Marshal
thing with a single linejson.Encode
call over stdout.Now calling this tool without any flag does:
Hope all this is ok with you!
r: @lukehoban