bugfix: pass meta to existsIndexTemplate method from OS API

[jaredbarranco]

Please see the issue from source project: vanthome/winston-elasticsearch#203

This is effectively a copy/paste of the solution proposed in PR: vanthome/winston-elasticsearch#235

Summary by CodeRabbit

• New Features
  • Enhanced connection management for bulk writing process
• Bug Fixes
  • Improved connection checking mechanism with retry support
• Chores
  • Updated connection state tracking in bulk writing class
  • Modified bulk writing process to ensure proper state checks before execution

[coderabbitai]

Warning

Rate limit exceeded

@jaredbarranco has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 38 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between a35a219 and 88ef63e.

📒 Files selected for processing (1)

• bulk_writer.js (3 hunks)

Walkthrough

The changes enhance the connection management and control flow of the BulkWriter class in bulk_writer.js. A new property, connected, has been introduced to track the Elasticsearch connection status. The start method now sets this property to true after the connection check. The append method has been modified to require both running and connected states to be true before proceeding with the bulk writing process. The existsIndexTemplate method call has also been updated to include an additional argument for improved control.

Changes

File	Change Summary
bulk_writer.js	- Added connected property initialized to false - Updated start method to set connected to true - Modified append method to check both running and connected - Updated existsIndexTemplate method call to include { meta: true }

Poem

🐰 In the code where connections weave,
A rabbit hops, and we believe.
Connected now, the writer's keen,
With every check, a bond unseen.
Through data streams, our tales ignite,
In the world of code, all feels just right! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Caution

Inline review comments failed to post. This is likely due to GitHub's limits when posting large numbers of comments.

Actionable comments posted: 1

🛑 Comments failed to post (1)

bulk_writer.js (1)

27-29: ⚠️ Potential issue

Risk of setting connected to true in the finally block
Because .finally() executes whether checkEsConnection succeeds or fails, this assignment may incorrectly set this.connected to true on failed connection attempts. Consider setting this.connected to true only upon successful connection, possibly in the .then() block of checkEsConnection.

 this.checkEsConnection(this.retryLimit)
-  .finally(() => {
+  .then(() => {
     this.connected = true;
-  });
+  })
+  .catch(() => {
+    this.connected = false;
+  });

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

  this.checkEsConnection(this.retryLimit)
    .then(() => {
      this.connected = true;
    })
    .catch(() => {
      this.connected = false;
    });

[lukasjhan]

LGTM. Thank you for contributing @jaredbarranco.
I'll deploy new version as soon as possible.