Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ColorProperty to set background color #10

Closed
wants to merge 2 commits into from

Conversation

jwendelmuth
Copy link

No description provided.

@lucasw
Copy link
Owner

lucasw commented Aug 29, 2016

Check out rviz ColorProperty.

@NikolasE
Copy link

NikolasE commented Aug 29, 2016

I think this would provide a bit too much choice. A purple background probably does not have many use cases.

@lucasw
Copy link
Owner

lucasw commented Aug 29, 2016

What if the Global Options Background Color were used?
Is there a use case where the rviz camera would need a different background color than the standard rviz render window?

@NikolasE
Copy link

I personally like to have a black RVIZ background to work with, but it does not look good if the image is integrated into a document (thesis or bugreport).

@lucasw
Copy link
Owner

lucasw commented Aug 30, 2016

It seems like the default behavior should be that the rviz camera background is the same as the main rviz window. If there is a need to have two different background colors at the same time, then there should be a full color property (and a checkbox to enable it, or can switching between them be handled otherwise?).

I like a color background to distinguish it from foreground objects that are frequently monochrome.

For future reference another useful capability would be to optionally have a transparent background in an rgba Image.

@lucasw
Copy link
Owner

lucasw commented Aug 31, 2016

Squashed and merged with c20d2bb

@lucasw lucasw closed this Aug 31, 2016
@lucasw lucasw changed the title added FloatProperty to set monochrome background color added ColorProperty to set background color Aug 31, 2016
@lucasw
Copy link
Owner

lucasw commented Aug 31, 2016

The background color doesn't match desired as revealed by #14 (channels are swapped), it will be corrected separate from this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants