This repository has been archived by the owner on Dec 1, 2017. It is now read-only.
Implemented reordering (through drag and drop). #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Hi, |
|
+1 |
|
This seems like a really elegant approach. What's stopping it from getting merged? |
|
I'm pretty sure I have a forked repo with these changes. If you want to include it in your project, the maven dependency should be com.staticbloc.twv:layouts:1.0.0 and com.staticbloc.twv:core:1.0.0 |
|
@eygraber did you just include your pull request/changes, or any other? |
|
I think I might've added some stuff to the decorators for convenience. You can look at the commit history in the fork. |
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lucasr As promised in #110. I'd say this is 99% done. I didn't do exhaustive testing, and scrolling leaves much to be desired. I also changed the sample slightly to add reordering on long press.
UPDATE:
Fixed scrolling. The only thing left to do would be real world testing, which I'm doing with some of my apps.