Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TNT explosions not removing metadata #3180

Merged
merged 2 commits into from
Jan 19, 2025
Merged

Fix TNT explosions not removing metadata #3180

merged 2 commits into from
Jan 19, 2025

Conversation

appgurueu
Copy link
Contributor

Fixes #3179. Check that:

  1. Metadata of nodes that are blasted is correctly removed. Easiest way to test that is via the sign as described in the issue.
  2. Metadata of nodes that aren't blasted is preserved. For example put something in a locked chest and check that it is still in there after the explosion.

sfan5
sfan5 reviewed Jan 18, 2025
View reviewed changes
mods/tnt/init.lua Outdated Show resolved Hide resolved
sfan5
sfan5 approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt, not tested

@appgurueu appgurueu merged commit 672b63f into luanti-org:master Jan 19, 2025
2 checks passed
@appgurueu appgurueu deleted the boom-meta branch January 19, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfan5 sfan5 sfan5 approved these changes

Assignees
No one assigned
Labels
Bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

explosions leave metadata behind
2 participants
@appgurueu @sfan5