Feat/humanize number helper #43
Merged
+285
−236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adSaim/lua into MuhammadSaim-ui-changes-humanize-number-helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve code readability and functionality in both the backend and frontend. The most important changes include modifying the
RedirectControllerto handle the$keyparameter more flexibly, improving the layout and formatting in Vue components, and enhancing the number formatting utility in the helper file.Backend Changes:
app/Http/Controllers/RedirectController.php: Modified the__invokemethod to handle the$keyparameter as optional and moved it after theRequestparameter for better flexibility.Frontend Changes:
resources/js/Pages/Link/Create.vueandresources/js/Pages/Link/Edit.vue: Improved the layout by adding a wrapperdivwith a flexbox layout and consistent indentation forLabelandInputErrorcomponents.resources/js/Pages/Link/Index.vue: Removed redundant HTML and improved the display of click counts by using a helper function for number formatting. [1] [2]Utility Enhancements:
resources/js/helper.js: Enhanced thekFormatterfunction to handle larger numbers and added support for formatting in billions and millions.