DM-33361: Prototype factories for loading cameraGeom. #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
force-pushed
the
tickets/DM-33361
branch
2 times, most recently
from
bc6ce7f to
058ac41
Compare
TallJimbo
force-pushed
the
tickets/DM-33361
branch
from
058ac41 to
0b46eb8
Compare
TallJimbo
force-pushed
the
tickets/DM-33361
branch
from
0b46eb8 to
f23023d
Compare
TallJimbo
commented
Mar 29, 2022
| associated with the full camera, such as the distortion model; similar | ||
| classes whose instances correspond to a single detector should implement | ||
| *only* `DetectorBuilderUpdater` instead. | ||
| """ |
There was a problem hiding this comment.
I don't think we currently have any IsrCalib classes that would want to implement this interface (they're all per-detector, not per-camera, AFAIK). It might be something that classes that represent optical distortions derived from astrometry might want to provide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prototype that is intended to support an RFC (with text motivating the concepts) before actually being merged.
Readers should start with the new methods in the
Instrumentclass before looking at the implementation in_camera_loaders.py.