Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed RSP portal panel #184

Merged
merged 2 commits into from
Aug 19, 2024
Merged

removed RSP portal panel #184

merged 2 commits into from
Aug 19, 2024

Conversation

RoyWilliams
Copy link
Contributor

I have removed the RSP portal panel because there is corresponding dataset in the RSP, so it makes to sense right now.

However I make a new issue detailing how to put back the work Gareth has done.

@RoyWilliams RoyWilliams requested a review from gpfrancis August 14, 2024 13:43
Copy link
Member

@gpfrancis gpfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. You could also just comment it out since we're intending to put it back as soon as there is something useful for it to point at.

@RoyWilliams
Copy link
Contributor Author

I tried XHTML comments but seems ineffective

@RoyWilliams RoyWilliams merged commit 8f520f8 into develop Aug 19, 2024
1 check passed
@RoyWilliams RoyWilliams deleted the hotfix/remove_rsp_portal branch August 19, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants