Add XML for ts_MOSS #906
Merged
Add XML for ts_MOSS #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmegh
force-pushed
the
tickets/DM-46263
branch
5 times, most recently
from
97e8e04 to
ed54b33
Compare
tribeiro
requested changes
Sep 16, 2024
| </SALCommand> | ||
| <SALCommand> | ||
| <Subsystem>MOSS</Subsystem> | ||
| <EFDB_Topic>MOSS_command_moveMountToAltAz</EFDB_Topic> |
There was a problem hiding this comment.
Please, remove this command. The MOSS CSC should not move the mount. If this is needed, it needs to be done externally by a script of something.
| </SALCommand> | ||
| <SALCommand> | ||
| <Subsystem>MOSS</Subsystem> | ||
| <EFDB_Topic>MOSS_command_moveMountToHomePosition</EFDB_Topic> |
There was a problem hiding this comment.
Please, remove this command. Same argument as above, MOSS should not be commanding the mount.
| <Description>Report the state of the flip attenuator</Description> | ||
| <item> | ||
| <EFDB_Name>state</EFDB_Name> | ||
| <Description>State of the flip attenuator, it can either be in place or removed</Description> |
There was a problem hiding this comment.
Please, create an enumeration to store the valid values.
| </SALEvent> | ||
| <SALEvent> | ||
| <Subsystem>MOSS</Subsystem> | ||
| <EFDB_Topic>MOSS_logevent_mountPosition</EFDB_Topic> |
There was a problem hiding this comment.
It is not the job of the MOSS to report mount position.
| <ActiveDevelopers>Guillem Megias</ActiveDevelopers> | ||
| <Github>https://github.com/lsst-ts/ts_moss</Github> | ||
| <JenkinsTestResults>https://tssw-ci.lsst.org/job/LSST_Telescope-and-Site/job/ts_moss/</JenkinsTestResults> | ||
| <RubinObsContact>Sandrine Thomas</RubinObsContact> |
There was a problem hiding this comment.
Is Sandrine the POC for this system?
gmegh
force-pushed
the
tickets/DM-46263
branch
from
c66e8a5 to
d53dd4e
Compare
gmegh
force-pushed
the
tickets/DM-46263
branch
from
d53dd4e to
b9da400
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.