tickets/DM-44757 #875
Merged
tickets/DM-44757 #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribeiro
requested changes
Jul 9, 2024
There was a problem hiding this comment.
A couple of additional follow up requests.
I think the Electrometer stopScan command does not need the groupId, but the startScan command does need it.
Also, you can now remove the value attributes that were previously required. These is no longer needed so you can remove these attributes to cleanup the CSC interface. If you don't want to do this now, please, issue a new ticket to do it later.
The attribute name should be groupId and not groupID.
| @@ -111,6 +118,13 @@ | |||
| <Units>unitless</Units> | |||
| <Count>1</Count> | |||
| </item> | |||
| <item> | |||
| <EFDB_Name>groupID</EFDB_Name> | |||
There was a problem hiding this comment.
I don't think stopScan needs a groupId
| @@ -99,6 +99,13 @@ | |||
| <Units>second</Units> | |||
| <Count>1</Count> | |||
| </item> | |||
| <item> | |||
| <EFDB_Name>groupID</EFDB_Name> | |||
There was a problem hiding this comment.
Please, rename it to groupId (lower case d).
| @@ -35,6 +35,13 @@ | |||
| <Units>unitless</Units> | |||
| <Count>1</Count> | |||
| </item> | |||
| <item> | |||
| <EFDB_Name>groupID</EFDB_Name> | |||
tribeiro
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited xml to take a group ID.