Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPM: Improve PDU and XUPS telemetry. #874

Merged
merged 1 commit into from
Jun 26, 2024
Merged

EPM: Improve PDU and XUPS telemetry. #874

merged 1 commit into from
Jun 26, 2024

Conversation

wvreeven
Copy link
Contributor

No description provided.

@wvreeven wvreeven requested a review from teweitsai June 26, 2024 13:30
Copy link
Contributor

@teweitsai teweitsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -15,6 +15,13 @@
<Subsystem>EPM</Subsystem>
<EFDB_Topic>EPM_pdu</EFDB_Topic>
<Description>Telemetry for Netbooter PDU devices.</Description>
<item>
<EFDB_Name>systemDescription</EFDB_Name>
<Description>System Description.</Description>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider to provide more details of "System Description.". Thanks!

@@ -0,0 +1 @@
Improve PDU and XUPS telemetry.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XUPS or UPS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XUPS. It is one type of UPS that the CSC supports and part of the telemetry items that were added are for that type of UPS.

@wvreeven wvreeven merged commit e4709f3 into develop Jun 26, 2024
6 checks passed
@wvreeven wvreeven deleted the tickets/DM-44577 branch June 26, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants