Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding three commands to tunable laser for the thermal sensor #781

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

JosephParsons
Copy link
Contributor

Adding three commands for the temperature control thermal sensor on the laser.

  1. Changing the temperature set point
  2. Turning it on
  3. Turning it off

@parfa30
Copy link
Contributor

parfa30 commented Dec 15, 2023

As part of this ticket, could we add some Events as well? Or perhaps you want to do that in a different ticket? The events would be:

  • Set point changed
  • Thermal system is On/Off
  • Laser fan turned ON (this is the fan that will be triggered on with the RPi)
  • 100Hz sound triggers interlock (this will also be triggered on the RPi)

I wonder also if we can read the PV on the Omron as part of telemetry?

@JosephParsons
Copy link
Contributor Author

As part of this ticket, could we add some Events as well? Or perhaps you want to do that in a different ticket? The events would be:

* Set point changed

* Thermal system is On/Off

* Laser fan turned ON (this is the fan that will be triggered on with the RPi)

* 100Hz sound triggers interlock (this will also be triggered on the RPi)

I wonder also if we can read the PV on the Omron as part of telemetry?

I never commented on this.
I added the setpoint and thermal system. The RPii related stuff I put in a subtask of the RPii ticket here:
https://jira.lsstcorp.org/browse/DM-42237

Copy link
Contributor

@parfa30 parfa30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me! @couger01, will you check that there are no issues with the xml structure and approve?

Copy link
Contributor

@couger01 couger01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JosephParsons JosephParsons merged commit b7b1113 into develop Jan 17, 2024
5 checks passed
@JosephParsons JosephParsons deleted the DM-42112 branch January 17, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants