Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tickets/dm 40878 #764

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Tickets/dm 40878 #764

merged 3 commits into from
Oct 17, 2023

Conversation

teweitsai
Copy link
Contributor

@teweitsai teweitsai commented Oct 5, 2023 •
edited
Loading

  • Add the new item copleyFaultStatus in MTRotator_electrical topic.
  • Rename the item offlineSubstate to faultSubstate in MTRotator_logevent_controllerState topic.
  • Add the new item drivesEnabled to MTRotator_logevent_configuration topic.

@teweitsai teweitsai force-pushed the tickets/DM-40878 branch 3 times, most recently from 11e9a2e to c9ab3bb Compare October 6, 2023 13:34
@teweitsai teweitsai requested a review from tribeiro October 6, 2023 15:20
tribeiro
tribeiro reviewed Oct 6, 2023
View reviewed changes
Copy link
Member

@tribeiro tribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. However I have a couple comments I hope you will consider before I can approve the PR.

doc/version-history.rst Outdated Show resolved Hide resolved
python/lsst/ts/xml/enums/MTRotator.py Show resolved Hide resolved
python/lsst/ts/xml/data/sal_interfaces/MTRotator/MTRotator_Events.xml Show resolved Hide resolved
tribeiro
tribeiro approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@tribeiro tribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok looks good. Let's see if we can change that enumeration on Tekniker's side.

@teweitsai teweitsai merged commit f677710 into develop Oct 17, 2023
4 checks passed
@teweitsai teweitsai deleted the tickets/DM-40878 branch October 17, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tribeiro tribeiro tribeiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teweitsai @tribeiro