DM-40956 Twilight Flats Script: Allow immediate tracking and ignoring tcs components #154
Conversation
| """Abstract method to set the instrument. Change the filter | ||
| and start tracking. | ||
| """ | ||
| # slew to desired field |
There was a problem hiding this comment.
This comment should be removed, no slew is happening here.
| @@ -242,14 +249,18 @@ def get_schema(cls): | |||
| description: If True, track sky. If False, keep az and el constant. | |||
| type: boolean | |||
| default: True | |||
| position_telescope: | |||
| description: If True, position telescope relative to the sun. \ | |||
| If False, assume the telescope is in correct position. | |||
There was a problem hiding this comment.
I really, really don't like this idea. We can't rely on the users to avoid a dangerous scenario. When this flag is False, could the users start taking images when the telescope is pointed due West at an elevation of 20 degrees? We need some protection against that.
If we are not going to slew the telescope, we should still assume that we have telescope telemetry and that we can check that the telescope position is not pointed at the sun and raise an exception if it is too close.
| @@ -209,3 +209,15 @@ async def slew_azel_and_setup_instrument(self, az, el): | |||
| filter=self.config.filter, | |||
| grating=self.config.grating, | |||
| ) | |||
|
|
|||
| async def setup_instrument(self, az, el): | |||
| """Abstract method to set the instrument. Change the filter | |||
There was a problem hiding this comment.
I don't think you want to put the start_tracking in the setup_instrument method...it's misleading. You could either rename this method and it's purpose or (an even better option) split the two.
| @@ -282,10 +293,13 @@ async def configure(self, config: types.SimpleNamespace): | |||
| if comp in self.camera.components_attr: | |||
| self.log.debug(f"Ignoring Camera component {comp}.") | |||
| setattr(self.camera.check, comp, False) | |||
| elif comp in self.tcs.components_attr: | |||
There was a problem hiding this comment.
This is also kind of scary, because the use case is that we really should only ignore the MTDome and MTDomeTrajectory. We should never ignore the MTCS for example, but it is allowed with the way this is configured.
No description provided.