Tickets/dm 46969 Create script for take_rotated_comcam.py #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iglesu
force-pushed
the
tickets/DM-46969
branch
from
01a0a45 to
d83e971
Compare
tribeiro
reviewed
Oct 24, 2024
| @@ -0,0 +1,186 @@ | |||
| # This file is part of ts_standardscripts | |||
| # You should have received a copy of the GNU General Public License | ||
| # along with this program. If not, see <https://www.gnu.org/licenses/>. | ||
|
|
||
| __all__ = ["TakeRotatedComCam", "Mode"] |
There was a problem hiding this comment.
I don't think you need to re-export Mode.
| """ | ||
| await super().configure(config) | ||
| self.config = config | ||
| self.angles = config.angles |
There was a problem hiding this comment.
you are already storing the entire config object, I don't think you need to also store angles as a separate attribute.
| az_wrap_strategy=WrapStrategy.NOUNWRAP, | ||
| ) | ||
|
|
||
| await self.mtcs.wait_for_inposition( |
There was a problem hiding this comment.
you don't need to do this here.. slew_icrs will only finish when it is in position.
iglesu
force-pushed
the
tickets/DM-46969
branch
from
d83e971 to
4dd0a52
Compare
tribeiro
approved these changes
Oct 25, 2024
| from lsst.ts.standardscripts.maintel.take_aos_sequence_comcam import ( | ||
| TakeAOSSequenceComCam, | ||
| ) | ||
| from lsst.ts.xml.enums.ATPtg import WrapStrategy |
There was a problem hiding this comment.
This should be MTPtg not ATPtg
There was a problem hiding this comment.
DARN!!! Of course! good catch!!
…gles - Takes images at a sequence of specified rotation angles - Integrates AOS sequence execution for each angle, either triplet (intra-focal, extra-focal and in-focus images), intra doublets (intra and in-focus) or extra doublets (extra and in-focus) sequences with ComCam. - unit test for TakeRotatedComCam
iglesu
force-pushed
the
tickets/DM-46969
branch
from
17a2c19 to
244e2df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rubinobs.atlassian.net/browse/DM-46969