DM-44873: Ensure pipeline names/subsets/paths are correct in ts_externalscripts
#130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edennihy
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
These changes look good. These repos utilize towncrier to generate the changelog for each release, can you please add a news fragment describing the changes? Instructions can be found here: https://github.com/lsst-ts/ts_externalscripts/blob/develop/doc/news/README.rst
* Switch instrument names in file path to match default:
* Latiss -> LATISS
* LsstComCam -> LSSTComCam
* Fix changes in pipeline definition names:
* findDefects.yaml -> cpDefects.yaml
* VerifyBias.yaml -> verifyBias.yaml (similar changes for
verifyDark.yaml and verifyFlat.yaml).
* Fix subset name change:
* gainFromFlatPairs -> cpPtcGainFromFlatPairs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update calibration code for cp_pipe/cp_verify changes due to RFC-1013.