Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-41536: Refactor LOVE stress and uptime tests for configuring URLs instead of domains #118

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

sebastian-aranda
Copy link
Contributor

PR to make tests more flexible so they can be used also for k8s deployments for instance. Also some docstrings were standardized and make_love_stress_tests.py was refactored to import the LOVEManagerClient class instead of defining it.

@sebastian-aranda sebastian-aranda force-pushed the tickets/DM-41536 branch 7 times, most recently from 88988c9 to 32f7d2d Compare November 7, 2023 16:51
Copy link
Contributor

@rbovill rbovill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGtM

@rbovill rbovill self-requested a review November 7, 2023 17:39
Copy link
Contributor

@rbovill rbovill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a set of unit tests to verify the secure location, in addition to the non-secure URL?

Copy link
Contributor

@rbovill rbovill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the secure location test. LGtM.

… domains

This make tests more flexible so they can be used also for k8s deployments for instance
@sebastian-aranda sebastian-aranda merged commit 81e0ddc into develop Nov 9, 2023
1 check passed
@sebastian-aranda sebastian-aranda deleted the tickets/DM-41536 branch November 9, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants