Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _base config to Electrometer #370

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Add _base config to Electrometer #370

merged 2 commits into from
Jan 13, 2025

Conversation

couger01
Copy link
Contributor

No description provided.

@couger01 couger01 requested a review from a team as a code owner December 16, 2024 19:00
@couger01 couger01 requested a review from teweitsai December 16, 2024 19:14
Copy link
Contributor

@teweitsai teweitsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

integration_time: 0.1
electrometer_type: "Keithley"
electrometer_model: "6517b"
electrometer_config: {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a new line at the end of file:
image

@couger01 couger01 force-pushed the tickets/DM-48162 branch 2 times, most recently from 816da9a to d649c46 Compare December 17, 2024 18:47
@couger01 couger01 requested a review from wvreeven January 13, 2025 21:12
Copy link
Contributor

@wvreeven wvreeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@couger01 couger01 merged commit 67d32e5 into develop Jan 13, 2025
1 check passed
@couger01 couger01 deleted the tickets/DM-48162 branch January 13, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants