Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45744 Implement ATBuilding CSC +790-148 #3

Merged
merged 15 commits into from
Aug 23, 2024
Merged

DM-45744 Implement ATBuilding CSC +790-148 #3

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
79652d6
Move simulation code from the test directory into the module directory
bbrondel Aug 14, 2024
3b45909
Modify open_vent_gate and close_vent_gate to take four ints instead o…
bbrondel Aug 15, 2024
2d4b001
Add tests for open_vent_gate and close_vent_gate with four ints
bbrondel Aug 15, 2024
a540183
Remove extraneous prints
bbrondel Aug 15, 2024
e78416d
Lint and isort
bbrondel Aug 15, 2024
e47987b
Add telemetry and events
bbrondel Aug 19, 2024
9c972cc
Minor cleanup
bbrondel Aug 20, 2024
d6f5ceb
Fixes for running with the CSC
bbrondel Aug 20, 2024
b7739ab
Behavioral improvements
bbrondel Aug 20, 2024
6c533a9
Fix broken tests
bbrondel Aug 20, 2024
87ebe93
Changes responsive to comments by @tribeiro
bbrondel Aug 21, 2024
4fdd35e
Remove megaind dependency
bbrondel Aug 22, 2024
5cabebc
Allow export of cast_string_to_type
bbrondel Aug 23, 2024
81078d3
Additional docstrings and type hinting
bbrondel Aug 23, 2024
40d5d59
Docstring documentation of cast_string_to_type return value
bbrondel Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/lsst/ts/vent/controller/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@
# along with this program. If not, see <https://www.gnu.org/licenses/>.

try:
from .version import * # Generated by sconsUtils
from .version import __version__ # Generated by sconsUtils
except ImportError:
__version__ = "?"

from .config import Config
from .controller import Controller, VentGateState
from .controller import Controller
from .dispatcher import Dispatcher
4 changes: 2 additions & 2 deletions python/lsst/ts/vent/controller/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ class Config:
port = 502
"""The default TCP port to connect to via modbus-TCP."""

slave = 1
"""The default modbus slave ID for the variable frequency drive."""
device_id = 1
"""The default modbus device ID for the variable frequency drive."""

max_freq = 50.0
"""Default maximum frequency for the dome fans."""
Expand Down
Loading
Loading