Refactor get_jira_obs_report method to account for JIRA REST API user timezone. #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvreeven
approved these changes
Nov 28, 2024
manager/manager/utils.py
Outdated
|
|
||
| Notes | ||
| ----- | ||
| Note that the JIRA REST API query is based on the user timezone so |
There was a problem hiding this comment.
Just an esthetic comment: You start the sentence with Note that the JIRA REST API... while you write this in de Notes section. Just write The JIRA REST API... and it's fine. Up to you if you want to change this or not. It is perfectly fine as it is.
There was a problem hiding this comment.
You are right, its kind of redundant jaja, I'll do the change 👍. Thank you!
sebastian-aranda
force-pushed
the
tickets/DM-47765
branch
from
3e1bdcf to
564a558
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
get_jira_obs_reportmethod to account for timezones when using the JIRA REST API so we don't rely on a hardcoded date range for queries which could affect if using different users to authenticate the query and also account for daylight saving time. Tests were extended to comply with these changes.