Fix issue with update_time_lost method #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-aranda
force-pushed
the
tickets/DM-46001
branch
from
2eaae8c to
d51e8ec
Compare
sebastian-aranda
force-pushed
the
tickets/DM-46001
branch
from
d51e8ec to
0461eaf
Compare
Also adjust method to read time lost parameter from the fields attribute in the Jira response
sebastian-aranda
force-pushed
the
tickets/DM-46001
branch
from
0461eaf to
bb6564d
Compare
Vebop
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
This looks good, @sebastian-aranda. Thank you for catching and doing integrated testing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue on the
update_time_lostmethod by not properly reading the time lost field from thefieldsattribute that comes on the jira ticket query. Also the time_lost field passed as argument of the function comes in string format, so that needs to be parsed tofloattoo so when adding time lost the code doesn't break.