Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust websockets routing as prefix is not needed anymore #276

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

sebastian-aranda
Copy link
Contributor

This PR fixes an issue with the websockets routing that was introduced after updating the LOVE-manager on #270. After updating the django dependency, we don't need anymore to force the prefix in base to the FORCE_SCRIPT_NAME setting. This is being added to the websocket path automatically now.

Copy link
Contributor

@mareuter mareuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sebastian-aranda sebastian-aranda merged commit 2f4688b into develop Aug 19, 2024
2 checks passed
@sebastian-aranda sebastian-aranda deleted the tickets/DM-45849 branch August 19, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants