Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(role/laserrpi) add new udev rule ttyusb #1611

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

cbarria
Copy link
Contributor

@cbarria cbarria commented Jan 13, 2025

this rule replaces the one with the fix vendor ID for a more generic rule that can be more managed.

@cbarria cbarria added the enhancement New feature or request label Jan 13, 2025
@cbarria cbarria self-assigned this Jan 13, 2025
@cbarria cbarria marked this pull request as ready for review January 13, 2025 19:21
@cbarria cbarria changed the title (role/laserrpi) add new udev rule ttyusb (draft) (role/laserrpi) add new udev rule ttyusb Jan 13, 2025
Copy link
Member

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is the intent to fully replace the profile::pi::ftdi profile class?

@cbarria
Copy link
Contributor Author

cbarria commented Jan 13, 2025

LGTM. Is the intent to fully replace the profile::pi::ftdi profile class?

Yes, i will deprecate the ftdi profile and propagate this changes to all rpi once it is ok 👍🏻

@cbarria cbarria merged commit e51f168 into production Jan 14, 2025
12 checks passed
@cbarria cbarria deleted the IT-5846_udev_usb branch January 14, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants