Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(hiera/common.yaml) add rsyslog logrotate #1213

Open
wants to merge 1 commit into
base: production
Choose a base branch
from
Open

(hiera/common.yaml) add rsyslog logrotate #1213

wants to merge 1 commit into from

Conversation

cbarria
Copy link
Contributor

@cbarria cbarria commented Jun 10, 2024 •
edited
Loading

are you constantly out of space on your disks? is your node always tainted with disk pressure? is your CNI complaining and your canal pods are unable to start? Well... logs are no longer going to be THAT problem, only if you click Approve 👌🏻

@cbarria cbarria changed the title (hiera/common.yaml) add rsyslog log rotate WIP (hiera/common.yaml) add rsyslog log rotate Jun 10, 2024
@cbarria cbarria changed the title WIP (hiera/common.yaml) add rsyslog log rotate (WIP) (hiera/common.yaml) add rsyslog log rotate Jun 10, 2024
@cbarria cbarria force-pushed the IT-5347_rsyslog_rotate branch from 6b3ecdc to 150b34c Compare June 10, 2024 23:45
@cbarria cbarria added the enhancement New feature or request label Jun 10, 2024
@cbarria cbarria force-pushed the IT-5347_rsyslog_rotate branch from 150b34c to ee6e969 Compare June 11, 2024 00:37
@cbarria cbarria self-assigned this Jun 11, 2024
@cbarria cbarria changed the title (WIP) (hiera/common.yaml) add rsyslog log rotate (hiera/common.yaml) add rsyslog logrotate Jun 11, 2024
@cbarria cbarria marked this pull request as ready for review June 11, 2024 00:52
jhoblitt
jhoblitt reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this tested on EL7 and EL8? It will probably work but I don't know how the existing /etc/logrotate.d.rsyslog are different.

@cbarria cbarria force-pushed the IT-5347_rsyslog_rotate branch from ee6e969 to 8ba8be0 Compare June 24, 2024 20:08
@cbarria
Copy link
Contributor Author

cbarria commented Jul 30, 2024

Was this tested on EL7 and EL8? It will probably work but I don't know how the existing /etc/logrotate.d.rsyslog are different.

this was tested on the foreman dev host with EL7 and some other EL8 cant recall the host 👍🏻

@cbarria cbarria force-pushed the IT-5347_rsyslog_rotate branch from 8ba8be0 to fd4ea3f Compare August 1, 2024 17:35
@cbarria cbarria requested a review from jhoblitt August 12, 2024 16:42
jhoblitt
jhoblitt reviewed Aug 12, 2024
View reviewed changes
Copy link
Member

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to apply to EL7, EL8, EL9, and the couple of Ubuntu nodes. Has this file been inspected on all of the platforms?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhoblitt jhoblitt jhoblitt left review comments

@csilva-cl csilva-cl Awaiting requested review from csilva-cl

@dtapiacl dtapiacl Awaiting requested review from dtapiacl

@igonzalezcl igonzalezcl Awaiting requested review from igonzalezcl

@badenerb badenerb Awaiting requested review from badenerb

At least 1 approving review is required to merge this pull request.

Assignees

@cbarria cbarria

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbarria @jhoblitt