Run7/step14

[seanmacb]

From discussion on the cam-summit-ops channel:

This is one of the items that needs fleshing out. I would like the following added as a 'Step':

DARKS with Shutter closed: 20 15sec DARK images taken with room lights off and Shutter CLOSED.  This measures the CCD dark current itself.  This previously passed our requirements, and this would be the re-verification.
DARKS with Shutter open: 20 15sec DARK images taken with room lights off and Shutter OPEN.  This tests for stray light inside the Camera.  And verifies that the previously know sources are now mitigated.

[jchiang87]

A have a couple of questions about the ordering of entries and SHUTTER values.

[jchiang87]

What does SHUTTER=None mean? I don't see it used anywhere else in this repo. I do see

SHUTTER  = CLOSE

in Run6/step13/opsimdark.cfg. Based that config, I would have expected the entries here to be

[DARK]
SHUTTER = CLOSE
BCOUNT=0
dark=15.0 20     # integration time and image count for dark set

with the SHUTTER = CLOSE entry before the dark=15.0 20 entry.

[seanmacb]

Explanation on the shutter entries is here.

There is no SHUTTER = CLOSE option supported. That is why I specify the comment at the head of the config file

[jchiang87]

Here is your comment:

 Before executing this config, make sure shutter is closed. The SHUTTER=None keyword

I don't know what "The SHUTTER=None keyword" is supposed to mean. That's why I asked.

[jchiang87]

Should SHUTTER = OPEN come before dark=15.0 20?

[seanmacb]

Based on the parsing of fp-scripts/acquire.py arguments, it should not matter the order of the keywords, so long as they are within the same block. Unless I am misunderstanding something?

[jchiang87]

I'm just asking a question, if that's ok. If the order doesn't matter, that's fine. I didn't write this code, but there are cases where the order does matter, e.g., in the flat pair acquisitions, so I wanted to ask to be sure. Please ask someone else to review your changes in the future.

[seanmacb]

Thank you for asking a question, and I apologize for not clarifying. I am not trying to be defensive or combative, and I understand that it reads that way. I apologize for my poor choice of words.

I was asking if I was misunderstanding because we have been fairly arbitrary with the ordering of keywords, and I was curious if the order did impact things.

Again, I apologize for being curt. That is not my intention.

[jchiang87]

Here is your comment:

 Before executing this config, make sure shutter is closed. The SHUTTER=None keyword

I don't know what "The SHUTTER=None keyword" is supposed to mean. That's why I asked.

[jchiang87]

I'm just asking a question, if that's ok. If the order doesn't matter, that's fine. I didn't write this code, but there are cases where the order does matter, e.g., in the flat pair acquisitions, so I wanted to ask to be sure. Please ask someone else to review your changes in the future.