-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup of readers #332
base: master
Are you sure you want to change the base?
Cleanup of readers #332
Conversation
This method was not used in the code anymore. The config xml was already used to set according values.
After grepping the whole project, it seems I'd be in favor of removing them! |
…unctional and are not further developed anymore
Regarding the MPI_IOCheckpointWriter and MPI_IOReader: I think it would be important to have a high-performance I/O plugin in ls1 for checkpointing. MPI functionality can bypass any type-conversions and allows optimal usage of parallel file systems like, e.g., Lustre. So it would be good to keep this. Note: I would also take over the maintainer role for this plugin :) |
I agree that it is important to have a high-performance IO in ls1. However, this should then be the default setting. From a user's perspective of view, you will not dig deep into the different plugins (btw, how many readers/writers are available in ls1? Probably a lot) and just use the default one or the ones from the examples. Those are mainly the binary checkpoint reader/writer and maybe the old ASCII reader/writer (the final-checkpoint option writes in ASCII afaik). So if we want to keep them, we should make them easily usable and set them as default. |
ASCII reader
The methodreadPhaseSpaceHeader
of the ASCII reader is not used in the code anymore. Instead, the data of the config xml was already employed to set according values.It seems that the method
readPhaseSpaceHeader
of the ASCII reader is just used for tests, see here.--> We will keep the ASCII reader for now.
MPI_IOCheckpointWriter
andMPI_IOReader
@cniethammer @FG-TUM
Do you know if the
MPI_IOCheckpointWriter
andMPI_IOReader
classes are in use or working at all?I couldn't find any reference and usage of those in the present code base.
On the history of the
MPI_IOCheckpointWriter
: