v.1.5.3 (#170)

lotusprey · Sep 24, 2024 · 9480a2a · 9480a2a
1 parent 703dd4e
commit 9480a2a
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 9 deletions.
diff --git a/.../metadata/android/en-US/changelogs/76.txt → .../metadata/android/en-US/changelogs/77.txt b/.../metadata/android/en-US/changelogs/76.txt → .../metadata/android/en-US/changelogs/77.txt
diff --git a/lib/feature/activity/activities_provider.dart b/lib/feature/activity/activities_provider.dart
@@ -1,7 +1,6 @@
 import 'dart:async';
 
 import 'package:flutter_riverpod/flutter_riverpod.dart';
-import 'package:otraku/extension/date_time_extension.dart';
 import 'package:otraku/extension/future_extension.dart';
 import 'package:otraku/feature/activity/activities_filter_model.dart';
 import 'package:otraku/feature/activity/activities_filter_provider.dart';
@@ -20,14 +19,17 @@ class ActivitiesNotifier
     extends AutoDisposeFamilyAsyncNotifier<Paged<Activity>, int> {
   late int viewerId;
   late ActivitiesFilter filter;
-  int _lastCreatedAt = DateTime.now().secondsSinceEpoch;
+
+  // Used to skip activities when fetching outdated pages.
+  int? _lastId;
 
   @override
   FutureOr<Paged<Activity>> build(arg) async {
     if (arg == homeFeedId) {
       ref.keepAlive();
     }
 
+    _lastId = null;
     viewerId = Persistence().id!;
     filter = ref.watch(activitiesFilterProvider(arg));
     return await _fetch(const Paged());
@@ -46,10 +48,10 @@ class ActivitiesNotifier
         'typeIn': filter.typeIn.map((t) => t.name).toList(),
         ...switch (filter) {
           HomeActivitiesFilter filter => {
+              'page': oldState.next,
               'isFollowing': filter.onFollowing,
               if (!filter.withViewerActivities) 'userIdNot': viewerId,
               if (!filter.onFollowing) 'hasRepliesOrText': true,
-              if (oldState.items.isNotEmpty) 'createdBefore': _lastCreatedAt,
             },
           UserActivitiesFilter filter => {
               'userId': filter.userId,
@@ -61,12 +63,14 @@ class ActivitiesNotifier
 
     final items = <Activity>[];
     for (final a in data['Page']['activities']) {
+      if (_lastId != null && a['id'] >= _lastId) continue;
+
       final item = Activity.maybe(a, viewerId, Persistence().imageQuality);
       if (item != null) items.add(item);
     }
 
     if (data['Page']['activities'].isNotEmpty) {
-      _lastCreatedAt = data['Page']['activities'].last['createdAt'];
+      _lastId = data['Page']['activities'].last['id'];
     }
 
     return oldState.withNext(

diff --git a/lib/util/graphql.dart b/lib/util/graphql.dart
@@ -539,12 +539,11 @@ abstract class GqlQuery {
 
   static const activityPage = r'''
     query Activities($userId: Int, $userIdNot: Int, $page: Int = 1, $isFollowing: Boolean,
-        $hasRepliesOrText: Boolean, $typeIn: [ActivityType], $createdBefore: Int) {
+        $hasRepliesOrText: Boolean, $typeIn: [ActivityType]) {
       Page(page: $page) {
         pageInfo {hasNextPage}
         activities(userId: $userId, userId_not: $userIdNot, isFollowing: $isFollowing,
-            hasRepliesOrTypeText: $hasRepliesOrText, type_in: $typeIn, sort: [PINNED, ID_DESC],
-            createdAt_lesser: $createdBefore) {
+            hasRepliesOrTypeText: $hasRepliesOrText, type_in: $typeIn, sort: [PINNED, ID_DESC]) {
           ... on TextActivity {...textActivity}
           ... on ListActivity {...listActivity}
           ... on MessageActivity {...messageActivity}

diff --git a/lib/util/persistence.dart b/lib/util/persistence.dart
@@ -10,7 +10,7 @@ import 'package:otraku/util/theming.dart';
 import 'package:path_provider/path_provider.dart';
 
 /// Current app version.
-const versionCode = '1.5.2';
+const versionCode = '1.5.3';
 
 /// General options keys.
 enum _OptionKey {

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -3,7 +3,7 @@ description: An unofficial AniList app.
 
 publish_to: 'none'
 
-version: 1.5.2+76
+version: 1.5.3+77
 
 environment:
   sdk: '>=3.0.0 <4.0.0'