✏️ 쿠폰 발급완료 사용여부 수정, 쿠폰조회 중복 수정

src/main/java/kr/bb/store/client/ProductFeignClient.java

@@ -32,7 +32,10 @@ default CommonResponse<StoreSubscriptionProductId> getSubscriptionProductIdFallb
         log.warn("{}'s Request of '{}' failed. request will return fallback data",
                 "ProductFeignClient", "getSubscriptionProductIdFallback");
         return CommonResponse.<StoreSubscriptionProductId>builder()
-                .data(null)
+                .data(StoreSubscriptionProductId.builder()
+                        .subscriptionProductId(null)
+                        .build()
+                )
                 .message("data from circuit")
                 .build();
     }

src/main/java/kr/bb/store/domain/coupon/facade/CouponFacade.java

@@ -38,7 +38,7 @@ public void useCoupons(ProcessOrderDto processOrderDto) {
             Long userId = processOrderDto.getUserId();
             String phoneNumber = processOrderDto.getPhoneNumber();
             orderStatusSQSPublisher.publish(userId, phoneNumber, NotificationKind.INVALID_COUPON);
-            throw e;
+            log.error("coupon use failed with cause of {}", e);
         }
     }
 

src/main/java/kr/bb/store/domain/coupon/repository/CouponRepositoryCustomImpl.java

@@ -90,13 +90,10 @@ public List<CouponWithIssueStatusDto> findStoreCouponsForUser(Long userId, Long
                             .where(
                                     issuedCoupon.id.couponId.eq(coupon.id),
                                     issuedCoupon.id.userId.eq(userId),
-                                    issuedCoupon.isUsed.isFalse(),
                                     coupon.isDeleted.isFalse()
                             )
                 ))
                 .from(coupon)
-                .leftJoin(issuedCoupon)
-                .on(coupon.id.eq(issuedCoupon.id.couponId))
                 .where(
                         coupon.store.id.eq(storeId),
                         isCouponUnexpired(now),

src/main/java/kr/bb/store/domain/coupon/service/CouponService.java

@@ -132,13 +132,15 @@ public Integer getMyAvailableCouponCount(Long userId, LocalDate now) {
     }
 
     public void validateCouponPrice(List<ValidatePriceDto> validatePriceDtos) {
-        validatePriceDtos.forEach(dto -> {
-            Coupon coupon = couponReader.read(dto.getCouponId());
-            Long receivedPaymentPrice = dto.getActualAmount();
-            Long receivedDiscountPrice = dto.getCouponAmount();
-            if(!coupon.isRightPrice(receivedPaymentPrice, receivedDiscountPrice)) {
-                throw new CouponInconsistencyException();
-            }
+        validatePriceDtos.stream()
+                .filter(dto -> dto.getCouponId() != null)
+                .forEach(dto -> {
+                    Coupon coupon = couponReader.read(dto.getCouponId());
+                    Long receivedPaymentPrice = dto.getActualAmount();
+                    Long receivedDiscountPrice = dto.getCouponAmount();
+                    if(!coupon.isRightPrice(receivedPaymentPrice, receivedDiscountPrice)) {
+                        throw new CouponInconsistencyException();
+                    }
         });
     }