New sequences #235
Open
New sequences #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzaremba
reviewed
May 6, 2018
| # Not sure if np.copy is needed here (see _IndexedSequence) | ||
| yield np.copy(self._base._get_frame(t)) | ||
| except NotImplementedError: | ||
| if self._indices[0].step < 0: |
There was a problem hiding this comment.
Not sure where the self._indices comes from.
What about if np.any(np.diff(self._times) <= 0): ?
There was a problem hiding this comment.
I *think this was copied in error over from indexed sequence. I can clean up the logic and then resubmit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found it convenient to add some wrapper sequences to assist with analysis. Not sure if these should go in sequences.py or some where else
SplicedSequences are useful for looking through a non-consecutive subset of frames of the base sequence (IndexedSequence seems to require a slice). For example when looking through frames identified as having possible motion correction errors.
NaNMean and Sequences are useful for collapsing 3D data to a single plane for visualization or further analysis