Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add some notes and a few refactors #7

Merged
merged 3 commits into from
Apr 3, 2024
Merged

docs: add some notes and a few refactors #7

merged 3 commits into from
Apr 3, 2024

Conversation

zxch3n
Copy link
Member

@zxch3n zxch3n commented Apr 3, 2024

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 78.4% 610 / 778
🔵 Statements 78.4% 610 / 778
🔵 Functions 86.95% 20 / 23
🔵 Branches 75.72% 78 / 103
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/lib.ts 88.4% 75.72% 100% 88.4% 92-93, 103-106, 111-112, 121-124, 129, 134-135, 182-183, 195-196, 225, 267-277, 294, 344, 348-349, 364, 368-369, 419-420, 442-450, 454-455, 562-563, 565, 567, 569, 579-590, 598, 600-604
src/sync-plugin.ts 31.88% 100% 0% 31.88% 42-90, 93-116, 118-138
Generated in workflow #12

bellini666
bellini666 approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@bellini666 bellini666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! :)

src/lib.ts Show resolved Hide resolved
src/lib.ts Outdated Show resolved Hide resolved
src/lib.ts Show resolved Hide resolved
src/lib.ts Outdated Show resolved Hide resolved
src/lib.ts Outdated Show resolved Hide resolved
src/sync-plugin.ts Outdated Show resolved Hide resolved
src/sync-plugin.ts Show resolved Hide resolved
zxch3n and others added 2 commits April 3, 2024 22:45
@zxch3n @bellini666
Update src/sync-plugin.ts
a0e9d28 
Co-authored-by: Thiago Bellini Ribeiro <[email protected]>
@zxch3n
fix: based on suggestions from comments
9cd7639 
and add a few more notes
@zxch3n zxch3n merged commit 34a1c29 into main Apr 3, 2024
1 check passed
@zxch3n zxch3n deleted the zxch3n/note branch April 3, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bellini666 bellini666 bellini666 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zxch3n @bellini666