Use dig in layouts guide ERB #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neanias
changed the title
✅ Deploy Preview for lookbook-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Good catch @neanias! Thanks for the PR. About the docs, I'd stay it makes sense to improve the syntax there as well, what do you think @allmarkedup? |
|
I'm happy to change the others as part of this PR if that helps the sweep? |
If one uses the suggested layout for the ViewComponent default layout, navigating to `localhost:3000/rails/view_components` will throw an error due to the deeply nested nature of the Lookbook params hash. Using `dig` allows for safe access into the hashes without causing problems if any of the keys don't exist. This sweeps other instances of deep hash access. Hash#dig was introduced in Ruby 2.3, so will be available in all supported versions of Lookbook.
|
I think that's the main ones. I found |
Spone
approved these changes
Jul 9, 2024
@neanias yep that should be fine I think. Many thanks for your time with this, will merge now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one uses the suggested layout for the ViewComponent default layout, navigating to
localhost:3000/rails/view_componentswill throw an error due to the deeply nested nature of the Lookbook params hash. Usingdigallows for safe access into the hashes without causing problems if any of the keys don't exist.Hash#dig was introduced in Ruby 2.3, so will be available in all supported versions of Lookbook.
There's a few other instances of
params[:some][:deep][:key]in the docs, but I thought this one may be a better target since it could cross the Lookbook boundary to ViewComponent.