Skip to content

Commit

Permalink
Refactor build workflow and setup.py: Remove wheel name setting logic…
Browse files Browse the repository at this point in the history
… and conditionally append acceleration tag for Windows platform
  • Loading branch information
royshil committed Nov 8, 2024
1 parent 386bd78 commit 38694b1
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
10 changes: 0 additions & 10 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -76,17 +76,7 @@ jobs:
run: |
python -c "import sys; sys.path.pop(0); import simpler_whisper; print(simpler_whisper.__file__)"
- name: Set wheel name
shell: pwsh
run: |
$wheelName = "wheel-${{ matrix.os }}-${{ matrix.platform }}-py${{ matrix.python-version }}"
if ("${{ matrix.acceleration }}" -ne "") {
$wheelName += "-${{ matrix.acceleration }}"
}
echo "WHEEL_NAME=$wheelName" >> $env:GITHUB_ENV
- name: Upload wheel
uses: actions/upload-artifact@v4
with:
name: ${{ env.WHEEL_NAME }}
path: dist/*.whl
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ def get_tag(self):

# Make version
pkg_version = "0.2.2"
if acceleration:
if platform.system() == "Windows" and acceleration:
pkg_version = f"{pkg_version}+{acceleration}"

setup(
Expand Down

0 comments on commit 38694b1

Please sign in to comment.