Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GC-1725: attempting to fix url regex #221

Merged
merged 2 commits into from
Oct 25, 2023
Merged

GC-1725: attempting to fix url regex #221

merged 2 commits into from
Oct 25, 2023

Conversation

siddharthpant92
Copy link
Contributor

@siddharthpant92 siddharthpant92 commented Oct 25, 2023 •
edited
Loading

Fixing the regex for signature_url

Attempting to suppress the warnings - same as https://github.com/lob/lob-ruby/pull/210/files

@siddharthpant92 siddharthpant92 merged commit 29cda2b into main Oct 25, 2023
0 of 2 checks passed
@siddharthpant92 siddharthpant92 mentioned this pull request Oct 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanfriss juanfriss juanfriss approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siddharthpant92 @juanfriss