-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a post
task to adjust the songboom every 11ish turns
#1998
base: main
Are you sure you want to change the base?
Conversation
SongBoom.dropProgress() === 11 && | ||
SongBoom.songChangesLeft() > 2 + Number(willDrunkAdventure), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might fire off during our free fights at start of day, and because songboom doesn't increment on free fights, we'll be losing out on our sing along meat
Suggested solution: The Adjust Songboom: Meat
task stays in post, but Adjust Songboom: Seasoning
goes to a task that only fires immediately before spending a turn in barf (so we avoid swapping to it during things like digitize, or sausage goblins, etc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How much meat do we actually get from running sing along against our free fights?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A significant amount if our meat% is high enough and we have a lot of free fights! I was getting 500-800 meat from my shadow rift fights, for example
myInebriety() < inebrietyLimit() && | ||
garboValue($item`Special Seasoning`) > MEAT_CLIP_VALUE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't actually want to restrict this to sober right? It's fine to swap while overdrunk since we can't sing along anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good shout
@Shiverwarp for some reason my brain refuses to understand what's going on here so I'm officially passing any semblance of a torch on this to you and trust you implicitly. When you have the time and the inclination, do with this as you wish. |
resolves #1938