Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a post task to adjust the songboom every 11ish turns #1998

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

horrible-little-slime
Copy link
Contributor

resolves #1938

Comment on lines +359 to +360
SongBoom.dropProgress() === 11 &&
SongBoom.songChangesLeft() > 2 + Number(willDrunkAdventure),
Copy link
Contributor

@Shiverwarp Shiverwarp Aug 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might fire off during our free fights at start of day, and because songboom doesn't increment on free fights, we'll be losing out on our sing along meat

Suggested solution: The Adjust Songboom: Meat task stays in post, but Adjust Songboom: Seasoning goes to a task that only fires immediately before spending a turn in barf (so we avoid swapping to it during things like digitize, or sausage goblins, etc)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much meat do we actually get from running sing along against our free fights?

Copy link
Contributor

@Shiverwarp Shiverwarp Aug 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A significant amount if our meat% is high enough and we have a lot of free fights! I was getting 500-800 meat from my shadow rift fights, for example

Comment on lines +355 to +356
myInebriety() < inebrietyLimit() &&
garboValue($item`Special Seasoning`) > MEAT_CLIP_VALUE,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't actually want to restrict this to sober right? It's fine to swap while overdrunk since we can't sing along anyway

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good shout

@horrible-little-slime
Copy link
Contributor Author

@Shiverwarp for some reason my brain refuses to understand what's going on here so I'm officially passing any semblance of a torch on this to you and trust you implicitly. When you have the time and the inclination, do with this as you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Songboom Special Seasonings?
2 participants