Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for Comma Chameleon #1416

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Pantocyclus
Copy link
Contributor

No description provided.

Copy link
Contributor

@horrible-little-slime horrible-little-slime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry that this will make affected codeblocks harder to maintain. At the very least, we should create libram support for comma chameleon before starting on this.

Comment on lines +171 to +188
const commaJellyfishValue =
sumNumbers(
[
1.0,
1.0 / 2.0,
1.0 / 3.0,
1.0 / 4.0,
1.0 / 5.0,
...Array(100)
.fill(0)
.map(() => 1.0 / 20.0),
]
.map((val) => (val * jellyPrice > meatFamiliarValue ? val * jellyPrice : 0))
.splice(
get("_spaceJellyfishDrops"),
get("_spaceJellyfishDrops") + potentialJellyfishTurns
)
) -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of using sumNumbers with map, just use sum; do the splice earlier in the process to make this work

Comment on lines +198 to +206
fullMenu.push(
menu({
canChooseMacro: true,
location: $location`Barf Mountain`,
includeExperienceFamiliars: false,
})
.filter((f) => f.familiar === $familiar`Comma Chameleon`)
.map(calculateOutfitValue)[0]
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't tell what it is you're trying to do here, but it doesn't seem like the best way to achieve it.

? $familiar`Pocket Professor`
: $familiar`Comma Chameleon`,
};
if (have(chip) && myFamiliar() === $familiar`Pocket Professor`) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chameleon can't equip chip, so that's not going to work

Math.min(40, pocketProfessorLectures() - get("_pocketProfessorLectures"))
);
}
visitUrl(`inv_equip.php?which=2&action=equip&whichitem=${toInt(chip)}&pwd`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to make the chameleon your familiar before calling this, or equip straight to the terrarium

@s-k-z
Copy link
Contributor

s-k-z commented Jun 22, 2023

Amulet coin isn't valued currently, if this pushes up the market price on those, it should be important to check if it's worth using it on them.

@docrostov
Copy link
Member

i am not going to close this issue but i am going to raise a point here -- the economic ramifications of this PR are... not great. in a 600 turn day, famjacks will be used 13-14 times by a comma owner trying to copy a robort. that's a hell of a lot of jacks per user. we already saw jacks prices go completely wild during cognac-mania; if garbo does this, we wouldn't -just- need an amulet coin check, we'd also need to add ways for garbo to only convert comma-to-robort for embezzler fights and/or additional major jacks handling. this also relies on users to be using keeping-tabs or philter to convert their jacks to robort equipment, AND relies on people not trying to capture that market. overall, my lean is this would cease to be profitable a week or two after implementation and leave the market for famjacks in flames. is this really worth it?

@Pantocyclus
Copy link
Contributor Author

The idea here is that it should equilibriate to a point where jacks are too expensive to be used every turn, but one can still eke value out of the first 5 jelly extracts and whatever other limited daily fam drops.

E.g. with a single jack one should expect to be able to grab the first 5 stench jelly drops, putting the value of that jack at >=150k (far above the value of a robort jack)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants