integration tests: setup LND #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orbitalturtle
changed the title
carlaKC
reviewed
Oct 12, 2023
There was a problem hiding this comment.
Awesome work!
Two high level comments:
- If we can easily submodule LND and save ourselves having a
go.mod, that would be great. - I think we should think about retries/state subscription for LND to keep our code simple but that can be a followup.
Also running into a makefile error:
Makefile:10: *** Recursive variable TMPDIR' references itself (eventually). Stop.`
orbitalturtle
force-pushed
the
itests-lnd-setup
branch
3 times, most recently
from
9dd2290 to
edee3f2
Compare
|
Ok I made those changes :) I managed to commandeer my partner's Macbook to figure out what the trouble was on MacOS (wish I had thought of that earlier) and I think it's solved now. Lmk if it works for you @carlaKC |
carlaKC
approved these changes
Oct 31, 2023
orbitalturtle
force-pushed
the
itests-lnd-setup
branch
from
edee3f2 to
c51022c
Compare
|
@carlaKC Awesome :) Thanks for all the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening #74