Add a nonce to data messages. #606
Merged
+32
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using unix nano as nonce.
boks1971
commented
Jan 26, 2025
roomclient.go
Outdated
| @@ -132,6 +133,8 @@ func (c *RoomServiceClient) SendData(ctx context.Context, req *livekit.SendDataR | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| // add a nonce to enable receiver to de-dupe | |||
| req.Nonce = mono.UnixNano() | |||
There was a problem hiding this comment.
Using monotonic unix nano as nonce, but it probably requires a different mechanism which can be replicated in all server sdks.
There was a problem hiding this comment.
maybe the high n (48?) bits could be random and the low bits could be a counter? or a 128bit uuid?
There was a problem hiding this comment.
okay, will make a 128 but UUID. Not sure if counter would be useful.
There was a problem hiding this comment.
Switched to 128-bit UUID in this commit - 2c9472e
paulwe
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using unix nano as nonce.Use 128-bit UUID bytes as nonce.