Support Multisegments for TTS input #1288
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 95a6fbe The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jayeshp19
changed the title
theomonnom
reviewed
Dec 24, 2024
theomonnom
reviewed
Dec 24, 2024
| @utils.log_exceptions(logger=logger) | ||
| async def _run_segments(): | ||
| async for input_stream in self._segments_ch: | ||
| await self._run(input_stream) |
There was a problem hiding this comment.
This will not reuse the existing connection? (I know Cartesia supports having multiple segments without disconnecting, 11labs may too but I'm not sure)
There was a problem hiding this comment.
I don't think 11labs supports it, I've updated code for rest of plugins to reuse ws connection
jayeshp19
force-pushed
the
multisegments-tts
branch
from
6aa7514 to
37bbfcc
Compare
jayeshp19
changed the title
theomonnom
reviewed
Jan 3, 2025
tests/test_tts.py
Outdated
| stream.end_input() | ||
| stream.flush() | ||
| if i == 1: | ||
| stream.end_input() | ||
|
|
||
| frames = [] | ||
| is_final = False |
There was a problem hiding this comment.
each segment should have its own is_final
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for multiple segments in tts input