-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add participant_disconnect and unlink methods, to reconnect human input #1125
base: main
Are you sure you want to change the base?
fix: Add participant_disconnect and unlink methods, to reconnect human input #1125
Conversation
🦋 Changeset detectedLatest commit: f095989 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thanks @theomonnom, could we get this merged so it makes it into the next release? |
Hey @brightsparc, probably sometimes this week, we're thinking about reworking this flow a bit |
@theomonnom I've updated this with changes from main so it's ready to land. Are there any more refactorings planned for this flow, or could we land this as is? |
@theomonnom is there still plans to land this? |
Fixes: #1124
This adds new method to disconnect a participant and refactors the inner methods to be class level.
vad.VADEvent
andstt.SpeechEvent
cc @theomonnom