Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role program access #750

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Role program access #750

merged 5 commits into from
Dec 3, 2024

Conversation

DeeTheDev
Copy link
Collaborator

Fixes #736

Allow roles to have program enrollments. Members with the same role should have access
to the enrollment program resources. This is similar to the member enrollments via organization
memberships.

  • Add migration for roles in program enrollments
  • Associate the member, enrollment and role models
  • Refactor dataset methods to also access role enrollments
  • Test
  • Expose :roles in program enrollments entity

Refactor how enrollees are exposed and listed in the frontend.
Ensure that roles are reflected in programs and enrollments CRUD pages.

Program Enrollment List

Screenshot 2024-12-02 at 1 01 20 PM

Program Detail Page - Enrollment RelatedList

Screenshot 2024-12-02 at 1 00 51 PM

Program Enrollment Detail Page

Screenshot 2024-12-02 at 1 01 32 PM

@DeeTheDev DeeTheDev added backend Involves changes to the backend API admin Admin site changes labels Dec 2, 2024
@DeeTheDev DeeTheDev requested a review from rgalanakis December 2, 2024 18:03
@DeeTheDev DeeTheDev self-assigned this Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 99.13043% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.74%. Comparing base (7f0d640) to head (9547a7f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/suma/program.rb 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #750   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files         468      468           
  Lines       21431    21523   +92     
=======================================
+ Hits        21161    21253   +92     
  Misses        270      270           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Allow roles to have program enrollments.
Members with the same role should have access
to the enrollment program resources.
This is similar to the enrollments via organization
memberships.

* Add migration for roles in program enrollments
* Associate the member, enrollment and role models
* Refactor dataset methods to also access role enrollments
* Expose :roles in program enrollments entity
Refactor how 'enrollee' are exposed and listed.
Ensure that roles are reflected in programs and
enrollments CRUD pages.
@rgalanakis rgalanakis merged commit 43f8205 into main Dec 3, 2024
3 checks passed
@rgalanakis rgalanakis deleted the role-program-access branch December 3, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Admin site changes backend Involves changes to the backend API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give members access to programs through roles
2 participants