Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin program ordinal field #742

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Admin program ordinal field #742

merged 3 commits into from
Nov 22, 2024

Conversation

DeeTheDev
Copy link
Collaborator

Fixes #735

Adds the ordinal field to the program create/update form.

Also stack description fields for multiline contexts.

Screenshot 2024-11-21 at 6 31 56 PM

@DeeTheDev DeeTheDev added backend Involves changes to the backend API admin Admin site changes labels Nov 21, 2024
@DeeTheDev DeeTheDev requested a review from rgalanakis November 21, 2024 23:33
@DeeTheDev DeeTheDev self-assigned this Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (701c08e) to head (de34235).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #742   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         468      468           
  Lines       21340    21342    +2     
=======================================
+ Hits        21071    21073    +2     
  Misses        269      269           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

value={resource.ordinal}
type="number"
label="Ordinal"
helperText="Lists programs from higher to lower ordinal values in the dashboard."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's lower to higher (0 ranks first)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, also rephrasing the sentence.

@DeeTheDev DeeTheDev requested a review from rgalanakis November 22, 2024 00:01
@rgalanakis rgalanakis merged commit 5ce63c4 into main Nov 22, 2024
5 checks passed
@rgalanakis rgalanakis deleted the admin-program-ordinal branch November 22, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Admin site changes backend Involves changes to the backend API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ordinal setting to admin programs
2 participants