Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order image #741

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Fix order image #741

merged 2 commits into from
Nov 21, 2024

Conversation

DeeTheDev
Copy link
Collaborator

@DeeTheDev DeeTheDev commented Nov 21, 2024

Fixes #738

Image was incorrectly in a conditional statement, move the code out.

Also found a small bug where an invisible edit button is still clickable, adding 'disabled' will now make it not-clickable.

@DeeTheDev DeeTheDev added the webapp Public frontend changes label Nov 21, 2024
@DeeTheDev DeeTheDev requested a review from rgalanakis November 21, 2024 23:02
@DeeTheDev DeeTheDev self-assigned this Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (701c08e) to head (6d061cb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #741   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         468      468           
  Lines       21340    21340           
=======================================
  Hits        21071    21071           
  Misses        269      269           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@rgalanakis rgalanakis merged commit ac38f56 into main Nov 21, 2024
5 checks passed
@rgalanakis rgalanakis deleted the fix-order-image branch November 21, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
webapp Public frontend changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix bug where feature image is not showing up in order history detail
2 participants