-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add program and enrollments concept #726
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tweak flaky spec Add 'current_time' helper to remove some time drift
Also had to update the CRUD endpoints to expose the correct items and test.
We don't need it anywhere
Also, allow enrollments to be approved and unenrolled in the detail page. And make programs searchable. Test.
* Add missing tests for program search endpoint
* Remove all Eligiblity pages * Refactor the EligiblityConstraints component into Programs * Update program/enrollment navlink icons * Change 'eligiblity constraint' references/contexts into 'programs'
Also add program :app_link_text for the dashboard 'call to action' program link.
need to update org page with enrollments in related list
This reverts commit 7bb6494.
Fix bug with members not looking at their org associations
And use the RelatedList 'addNew' syntax in detail pages that create resources. Some misc. cleanup
Also, only expose the combined program enrollments in the Dashboard entity, rather than the member entity, not nessesary right now.
Require both app link and require
Faster and simpler
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #726 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 464 463 -1
Lines 20959 21039 +80
=======================================
+ Hits 20691 20770 +79
- Misses 268 269 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We implemented the concept of 'Programs' for members based on the Portland Water Bureau RAMP program pilot. In figuring out what a program is and reviewing the current backend components, we noticed that programs would remove a lot of complexity around member eligibility constraints, and the way we represent goods in member dashboards.
Eligibility constraints are technically duplicates of organization memberships, and both are used to verify a member. Instead, we replace eligibility constraints with programs. Members or organizations can be in program enrollments. Resources like food offerings and vendor services can be in programs. Changes include:
Vendible::Grouping
dashboard list is replaced byProgram
detail list that a member is enrolled in.Eligibility::Constraint
associations are replaced withPrograms
Eligibility::Constraint
associations are replaced withProgram::Enrollment
, and organizations can be associated with program enrollments tooThen the backend logic of member resource eligibility is replaced with, 'a user can access an offering/service if the user has an approved program enrollment (or the user is a verified member of an organization with an approved program enrollment) in an active program that is associated with the offering/service'.
Sets a 'now' key and API method helper in the env which we can use across the API and model layer of requests. This avoids many different definitions of 'now' within an endpoint/entity.
Admin pages replace eligibility constraints with programs and program enrollments. Also removes 'vendible groups', not necessary anymore.
Members with a positive ledger cash balance, will see their available amount on the top of the dashboard page
Dashboard program list
Details, image and link to the program promotion page.