Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin ability to soft delete and update phone of a member #719

Merged
merged 7 commits into from
Oct 16, 2024

Conversation

DeeTheDev
Copy link
Collaborator

@DeeTheDev DeeTheDev commented Oct 11, 2024

Right now, developers can manually soft delete and update a members phone number. We need the ability to do it through the admin portal. These changes add these abilities to helps suma staff mitigate member duplication during the member onboarding verification process.

Member soft deleting steps

Screenshot 2024-10-15 at 10 53 18 AM Screenshot 2024-10-15 at 10 53 29 AM

Update member phone number

Screenshot 2024-10-15 at 10 54 28 AM Screenshot 2024-10-15 at 10 54 51 AM

@DeeTheDev DeeTheDev added backend Involves changes to the backend API admin Admin site changes labels Oct 11, 2024
@DeeTheDev DeeTheDev requested a review from rgalanakis October 11, 2024 18:46
@DeeTheDev DeeTheDev self-assigned this Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (600af09) to head (0e86869).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #719   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         463      463           
  Lines       20946    20953    +7     
=======================================
+ Hits        20678    20686    +8     
+ Misses        268      267    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

}}
>
<Button onClick={handleDelete} variant="contained" color="error" size="small">
Soft Delete Member {id}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Soft Delete Dee Velasquez (555-123-4444)"

type="tel"
variant="outlined"
fullWidth
helperText="11-digit US phone number, begins with 1."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if it's taken? We get a nice error?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly I want to make sure we explain that the member with the number already, would need to be deleted first.

@DeeTheDev
Copy link
Collaborator Author

DeeTheDev commented Oct 15, 2024

@rgalanakis Thanks for the review, I updated the phone number validation message with some instructions and tested it through the member update API call. I think it's okay since we don't allow members to update their own number, so they won't ever see that validation message.

While updating the 'delete' button context, full names could be very long and cause styling issues so I truncated to the first 2 words in the name.

@rgalanakis rgalanakis force-pushed the admin-member-duplication branch from 0adba0d to 0e86869 Compare October 16, 2024 20:46
@rgalanakis rgalanakis merged commit e4129bb into main Oct 16, 2024
5 checks passed
@rgalanakis rgalanakis deleted the admin-member-duplication branch October 16, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Admin site changes backend Involves changes to the backend API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants