-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin ability to soft delete and update phone of a member #719
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #719 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 463 463
Lines 20946 20953 +7
=======================================
+ Hits 20678 20686 +8
+ Misses 268 267 -1 ☔ View full report in Codecov by Sentry. |
}} | ||
> | ||
<Button onClick={handleDelete} variant="contained" color="error" size="small"> | ||
Soft Delete Member {id} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Soft Delete Dee Velasquez (555-123-4444)"
type="tel" | ||
variant="outlined" | ||
fullWidth | ||
helperText="11-digit US phone number, begins with 1." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if it's taken? We get a nice error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly I want to make sure we explain that the member with the number already, would need to be deleted first.
@rgalanakis Thanks for the review, I updated the phone number validation message with some instructions and tested it through the member update API call. I think it's okay since we don't allow members to update their own number, so they won't ever see that validation message. While updating the 'delete' button context, full names could be very long and cause styling issues so I truncated to the first 2 words in the name. |
0adba0d
to
0e86869
Compare
Right now, developers can manually soft delete and update a members phone number. We need the ability to do it through the admin portal. These changes add these abilities to helps suma staff mitigate member duplication during the member onboarding verification process.
Member soft deleting steps
Update member phone number