Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup image alts #717

Merged
merged 7 commits into from
Oct 17, 2024
Merged

Cleanup image alts #717

merged 7 commits into from
Oct 17, 2024

Conversation

DeeTheDev
Copy link
Collaborator

Fixes #709

This cleans up image alts by:

  1. Adding all alt strings in one location - at the top of the 'strings' file
  2. Create function that will apply image alt best practices to the localized alt strings - could be helpful in the future if we have to make global alt changes
  3. Use function on images
  4. Remove redundant alts - mostly in the food images where the image alt name is the same as the product name next to it.
  5. All alts are reviewed and mitigated.

In the future, we can use the 'SumaImage' component to render image captions as alts. Rather than creating alt strings in the frontend, we could manually update alts In the admin app.

@DeeTheDev DeeTheDev added the webapp Public frontend changes label Oct 4, 2024
@DeeTheDev DeeTheDev self-assigned this Oct 4, 2024
@DeeTheDev DeeTheDev changed the title Image alts Cleanup image alts Oct 4, 2024
Comment on lines 288 to 289
"scooter_icon": "Símbolo De Patineta",
"scooter_icon_container": "Contenedor De Símbolo De Patineta",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove these, they're unused, english too

@DeeTheDev DeeTheDev requested a review from rgalanakis October 7, 2024 16:41
DeeTheDev and others added 7 commits October 17, 2024 16:02
- Localize strings that aren't translated
- Update strings that don't describe the image correctly
Also fix unlocalized string
    Ensure that we set best practices to all alts.
    - Create 'alts' section and add alt strings in the 'strings' localization file
    - Create function that adds best practices to the localized string
    - Use function where alts translations are neede
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (e4129bb) to head (293f939).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #717   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         463      463           
  Lines       20953    20953           
=======================================
  Hits        20686    20686           
  Misses        267      267           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rgalanakis rgalanakis merged commit 4ba3d46 into main Oct 17, 2024
5 checks passed
@rgalanakis rgalanakis deleted the image-alts branch October 17, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
webapp Public frontend changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup image alts
2 participants