-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup image alts #717
Cleanup image alts #717
Conversation
webapp/public/locale/es/strings.json
Outdated
"scooter_icon": "Símbolo De Patineta", | ||
"scooter_icon_container": "Contenedor De Símbolo De Patineta", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove these, they're unused, english too
- Localize strings that aren't translated - Update strings that don't describe the image correctly
Also fix unlocalized string
Ensure that we set best practices to all alts. - Create 'alts' section and add alt strings in the 'strings' localization file - Create function that adds best practices to the localized string - Use function where alts translations are neede
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #717 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 463 463
Lines 20953 20953
=======================================
Hits 20686 20686
Misses 267 267 ☔ View full report in Codecov by Sentry. |
Fixes #709
This cleans up image alts by:
In the future, we can use the 'SumaImage' component to render image captions as alts. Rather than creating alt strings in the frontend, we could manually update alts In the admin app.