Fix ledgers pagination layout #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove pagination if there are no lines - Also, since an empty space looks weird, add a 'no transactions' message
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #706 +/- ##
=======================================
Coverage 97.96% 97.96%
=======================================
Files 448 448
Lines 20497 20497
=======================================
Hits 20079 20079
Misses 418 418 ☔ View full report in Codecov by Sentry. |
rgalanakis
reviewed
Sep 17, 2024
webapp/src/pages/LedgersOverview.jsx
Outdated
| scrollTop={140} | ||
| /> | ||
| ) : ( | ||
| <p className="text-center">{t("payments:no_transaction_history")}</p> |
There was a problem hiding this comment.
This isn't true, so is confusing- they can be looking at an empty ledger but have spent money elsewhere. Either rephrase or remove.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #701
Remove pagination if there are no lines. Also, since an empty space looks weird, add a 'no transactions' message.