Reimplement frontend localization #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just the backend change.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #705 +/- ##
==========================================
+ Coverage 97.95% 97.97% +0.02%
==========================================
Files 448 449 +1
Lines 20493 20664 +171
==========================================
+ Hits 20074 20246 +172
+ Misses 419 418 -1 ☔ View full report in Codecov by Sentry. |
Use the new preprocessed files for rendering. They include if we need markdown or plain renderer, and the code is 4kb vs. 120kb.
We need to handle nested localizations, where: - `"abc": "**hi**"`, uses the `m` formatter, and - `"s1": "$t(abc)"`, depends on `abc`, but doesn't know it will need markdown. So we do a first pass to find all the 'naive' formatters, and then another pass where we look at all the formatters for all the (recursive) nestings, so we'd know that `s1` gets `m` in our example. This required a pretty big refactor, with internal classes to keep track of the nestings, and now we have more friendly formatter classes. But fundamentally everything works the same as the previous commit (and the output format didn't change at all).
rgalanakis
force-pushed
the
reformat-loc-rez-strings
branch
from
a118cf7 to
d95630f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a backend preprocessor to process localization files into a version that 1) indicates what formatter to use (plain, markdown without paragraphs, markdown with paragraphs) and a simpler interpolation (a single '@%' placeholder and an argument for each substitution). Each substitution argument indicates if it is just an option lookup, has a formatter, or points to another localization string.
The frontend code has been adjusted to load, lookup, and apply these preprocessed transformations. We didn't need to change most callsites; but we do get rid of the md/mdp formatters since the formatter is in the preprocessed file, which was the point of this work in the first place. So it's just the 'localization backend functions' that changed.
The new 'localization backend' is based on i18next (which is now gone), but is not meant to recreate the entire thing, just the parts we use and find valuable.
Fixes #308 (saves 110kb) and fixes #694.