Improve admin DateTimePicker to something safer to use #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #704 +/- ##
=======================================
Coverage 97.95% 97.96%
=======================================
Files 448 448
Lines 20493 20493
=======================================
+ Hits 20074 20075 +1
+ Misses 419 418 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #699
DateTimePicker values were formatted to the current date-time and was also leaving in the seconds e.g 12:25:44. Admin never had control over seconds and this caused issues e.g. multiple unexpected subsidy payment triggers active.
Since we only care about the hour and minute right now and we want to avoid adding a 'seconds' field to the DateTImePicker, instead we re-created a safe reusable-component that can format time correctly, specially truncating seconds to 0.