-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preferences #590
Preferences #590
Conversation
lib/suma/admin_api/members.rb
Outdated
@@ -188,5 +188,7 @@ class DetailedMemberEntity < MemberEntity | |||
expose :sessions, with: MemberSessionEntity | |||
expose :orders, with: MemberOrderEntity | |||
expose :message_deliveries, with: MessageDeliveryEntity | |||
expose :preferences, with: MessagePreferenceSubscriptionEntity, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is ideal (should be like {preferences: {subscriptions: []}}
but it's admin so easy to change later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DeeTheDev as I mentioned elsewhere, we need to expose the 'public url' in admin (the one to /preferences-public with the auth token). This is important because it's what CS will give out if someone wants to unsubscribe.
Fixes #579
Frontend:
Preferences
component to be used with routes:/preferences
for authenticated members/preferences-public
for members that have been provided an access token (to allow preference changes)Admin:
MemberDetailsPage
"Webapp top navigation "preferences" tab
Preferences page
Preferences saved message (when member authenticated)
Preferences saved message (when member NOT authenticated)
Admin Messaging Preferences section