-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Food flow changes #552
Merged
Merged
Food flow changes #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 'buffer' property in PageLoader components where necessary - Ensure consistent `LayoutContainer` gutters - When loading lists, ensure `PageLoader` placed correctly - Localize new strings - `OrderDetail` confirmation alert should live at the top, not the bottom - `OrderHistoryList` -> if an order is claimed, add that detail to the card
- Remove `FoodDetails` page "eligible for.." context - Update subsidy and discounts context into a sentence rather than inline totals - `OrderDetail` update edit-button location and fix styling shift - `OrderDetail`, add press and hold button warning so members don't accidently click - Do not display credit/discount details in the `FoodList`, we only display the customerPrice/Discount, we show details in the Detail page - `FoodPrice` add condition to show discounts when there is a difference between `customerPrice` and `undiscountedPrice` totals - Localize all new translations and remove unnecessary ones
- Fix incorrect discount/subsidy context in FoodDetail - FooDetail, move vendor below the divider line - Fix showing of the available credit on the FoodCart page - apply the subsidy for the subtotal (show $10 instead of $90) - ensure the offering can be paid at checkout without problems - Fulfillment options have link to address in google maps - "checkout whats available" typo, -> "what's" - FoodDetail, change order of discount and subsidy credit context
DeeTheDev
added
backend
Involves changes to the backend API
webapp
Public frontend changes
labels
Nov 17, 2023
Merging without review primarily because we need these changes by tomorrow. @rgalanakis To review tomorrow and deploy to production in heroku. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #538
Layout changes
LayoutContainer
guttersPageLoader
placed correctlyOrderDetail
confirmation alert should live at the top, not the bottomOrderHistoryList
-> if an order is claimed, change context to "claimed on [date]"First team requested changes:
FoodDetails
page "eligible for.." contextOrderDetail
update edit-button location and fix styling shiftOrderDetail
, add press and hold button warning so members don't accidently clickFoodList
, we only display the customerPrice/Discount, we show details in the Detail pageFoodPrice
add condition to show discounts when there is a difference betweencustomerPrice
andundiscountedPrice
totalsSecond team review requested changes
Additional changes