Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Food flow changes #552

Merged
merged 10 commits into from
Nov 17, 2023
Merged

Food flow changes #552

merged 10 commits into from
Nov 17, 2023

Conversation

DeeTheDev
Copy link
Collaborator

Fixes #538

Layout changes

  • Add 'buffer' property in PageLoader components where necessary
  • Ensure consistent LayoutContainer gutters
  • When loading lists, ensure PageLoader placed correctly
  • Localize new strings
  • OrderDetail confirmation alert should live at the top, not the bottom
  • OrderHistoryList -> if an order is claimed, change context to "claimed on [date]"

First team requested changes:

  • Remove FoodDetails page "eligible for.." context
  • Update subsidy and discounts context into a sentence rather than inline totals
  • OrderDetail update edit-button location and fix styling shift
  • OrderDetail, add press and hold button warning so members don't accidently click
  • Do not display credit/discount details in the FoodList, we only display the customerPrice/Discount, we show details in the Detail page
  • FoodPrice add condition to show discounts when there is a difference between customerPrice and undiscountedPrice totals
  • Localize all new translations and remove unnecessary ones

Second team review requested changes

  • Fix incorrect discount/subsidy context in FoodDetail
  • FooDetail, move vendor below the divider line
  • Fix showing of the available credit on the FoodCart page
  • apply the subsidy for the subtotal (show $10 instead of $90)
  • ensure the offering can be paid at checkout without problems
  • Fulfillment options have link to address in google maps
  • "checkout whats available" typo, -> "what's"
  • FoodDetail, change order of discount and subsidy credit context

Additional changes

  • Update loaderRing icon to take full with and height of the viewport, update class and styling
  • Cart quantity loading sign (Rob contribution)

DeeTheDev and others added 10 commits November 10, 2023 14:02
- Add 'buffer' property in PageLoader components where necessary
- Ensure consistent `LayoutContainer` gutters
- When loading lists, ensure `PageLoader` placed correctly
- Localize new strings
- `OrderDetail` confirmation alert should live at the top, not the bottom
- `OrderHistoryList` -> if an order is claimed, add that detail to the card
- Remove `FoodDetails` page "eligible for.." context
- Update subsidy and discounts context into a sentence rather than inline totals
- `OrderDetail` update edit-button location and fix styling shift
- `OrderDetail`, add press and hold button warning so members don't accidently click
- Do not display credit/discount details in the `FoodList`, we only display the customerPrice/Discount, we show details in the Detail page
- `FoodPrice` add condition to show discounts when there is a difference between `customerPrice` and `undiscountedPrice` totals
- Localize all new translations and remove unnecessary ones
- Fix incorrect discount/subsidy context in FoodDetail
- FooDetail, move vendor below the divider line
- Fix showing of the available credit on the FoodCart page
- apply the subsidy for the subtotal (show $10 instead of $90)
- ensure the offering can be paid at checkout without problems
- Fulfillment options have link to address in google maps
- "checkout whats available" typo, -> "what's"
- FoodDetail, change order of discount and subsidy credit context
@DeeTheDev DeeTheDev added backend Involves changes to the backend API webapp Public frontend changes labels Nov 17, 2023
@DeeTheDev DeeTheDev added this to the Turkey Hacking 2024 milestone Nov 17, 2023
@DeeTheDev
Copy link
Collaborator Author

Merging without review primarily because we need these changes by tomorrow. @rgalanakis To review tomorrow and deploy to production in heroku.

@DeeTheDev DeeTheDev merged commit 6fde34f into main Nov 17, 2023
3 checks passed
@DeeTheDev DeeTheDev deleted the food-flow-changes branch November 17, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Involves changes to the backend API webapp Public frontend changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overhaul food flow UI
2 participants